[FIXED] Freeze n.Applied for consumer when shutting down (#6133)

Similar to #6087, but for consumers. During shutdown we can't guarantee we'll still flush all that is needed. So don't touch `n.Applied` and rely on replay so those changes can be properly persisted. Signed-off-by: Maurice van Veen <[email protected]>
nats-io · Nov 14, 2024 · 40b3042 · 40b3042
2 parents b324c5f + f07c091
commit 40b3042
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/server/jetstream_cluster.go b/server/jetstream_cluster.go
@@ -4949,7 +4949,11 @@ func (js *jetStream) monitorConsumer(o *consumer, ca *consumerAssignment) {
 						doSnapshot(true)
 					}
 				} else if err := js.applyConsumerEntries(o, ce, isLeader); err == nil {
-					ne, nb := n.Applied(ce.Index)
+					var ne, nb uint64
+					// We can't guarantee writes are flushed while we're shutting down. Just rely on replay during recovery.
+					if !js.isShuttingDown() {
+						ne, nb = n.Applied(ce.Index)
+					}
 					ce.ReturnToPool()
 					// If we have at least min entries to compact, go ahead and snapshot/compact.
 					if nb > 0 && ne >= compactNumMin || nb > compactSizeMin {