-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goroutine leak after closing Logger #205
Comments
Personally I would add channel closing function to Close method, but comment says it explicitly close current file, not logger (which btw a bit misleading) // Close implements io.Closer, and closes the current logfile.
func (l *Logger) Close() error {
l.mu.Lock()
defer l.mu.Unlock()
if l.millCh != nil {
close(l.millCh)
l.millCh = nil
}
return l.close()
} |
I met the same problem too. Please fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Close command on logger does not close
mill
goroutineReproducer:
Then press Ctrl-4 (or use pprof to get all stacks)
The text was updated successfully, but these errors were encountered: