Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional order labeling #59

Open
Symiaq opened this issue Jan 6, 2021 · 4 comments
Open

Add optional order labeling #59

Symiaq opened this issue Jan 6, 2021 · 4 comments

Comments

@Symiaq
Copy link

Symiaq commented Jan 6, 2021

Adding the possibility to label trades would increase the possibility to document trades in an easier way for taxation.
In my case one finished trade consists out of three unique orders. Giving all of them the same ID would allow me to connect all three orders in a simple way. Especially when they aren't processed at the same time.

@Bi0max
Copy link

Bi0max commented Mar 22, 2021

It's very important to be able to give your own ID to orders. Otherwise, it is hard to track orders.
It's also potentially dangerous, because order_id (assigned by Nash) can be lost, before it is saved to DB. Imagine, that after placing an order there was some DB connection error. Then order is then completely lost, because system does not know its ID.

@Bi0max
Copy link

Bi0max commented Mar 26, 2021

@jankjr , could you pls check? it's a very important issue.

@MehdiSangtarash
Copy link

This will help me a lot too.

@MehdiSangtarash
Copy link

@localhuman @lucianoengel @alanpeabody any updates on this. it causes me problems on a daily, specially when there is connection time out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants