-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit format-check job doesn't run on push triggers #494
Comments
Do we need to check the commit message if it isn't part of a pull request? I push things for testing frequently that aren't ever intended for a pull request, so they don't follow the rules so it would just be noise. |
That's a good point. I only noticed it because it didn't run on the merge to main for PRs and I wanted to see "all greens". We can close as "won't fix" |
Checklist (Please check before submitting)
Describe the bug
When a new commit is pushed the commit format checker job in the format-check workflow does not run unless the commit is part of a pull request.
To Reproduce
Create new branch
Push commit with non-standard message to remote
Observe "Commit check" job skip
Expected behavior
Pull request format check is skipped
Commit format check executes
Code snips
cFS/.github/workflows/format-check.yml
Lines 69 to 76 in ff88a1e
The
if
statement should apply to the PR check step instead of the whole jobSystem observed on:
Github Actions. See screenshot for example
Additional context
None
Reporter Info
Gerardo E. Cruz-Ortiz | NASA
The text was updated successfully, but these errors were encountered: