Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI not properly monitoring code coverage #148

Open
asgibson opened this issue Aug 8, 2024 · 2 comments
Open

CI not properly monitoring code coverage #148

asgibson opened this issue Aug 8, 2024 · 2 comments

Comments

@asgibson
Copy link
Contributor

asgibson commented Aug 8, 2024

CI is not checking code coverage. Upon failure to check still shows as good for merging.
@dragonejt
Copy link
Contributor

I can take a look at this. To be clear, we want to fail the GitHub Actions workflow if the upload coverage to Codecov step fails?

@dragonejt
Copy link
Contributor

So I did try this by adding the fail_ci_if_error flag to the Codecov GitHub action. What happened was that most forks and pull requests from forks don't have access to that Codecov, so they were unable to upload and the GitHub Actions workflow failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dragonejt @asgibson