Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul buttons and components to use boolean properties #59

Open
lklyne opened this issue Mar 29, 2023 · 5 comments
Open

Overhaul buttons and components to use boolean properties #59

lklyne opened this issue Mar 29, 2023 · 5 comments
Assignees
@bwhuffman
Labels
figma items related to improving design assets + organization in figma

Comments

@lklyne
Copy link
Collaborator

lklyne commented Mar 29, 2023

No description provided.

@bwhuffman
Copy link
Member

Changes in this overhaul:

  • Implemented component properties
    • Showing icons
    • Swapping icons
    • Text
  • Naming standardization
    • “State" variant properties
    • "Size" variant properties
    • Uniform capitalization in naming
  • Added Dark mode in atomic toggle, radio, and checkbox components

@camargo
Copy link
Member

camargo commented Apr 5, 2023

Should this issue be in the react repo? If so we should transfer it

@bwhuffman
Copy link
Member

Hmm these changes are strictly in Figma. So I think this is correct?

@camargo
Copy link
Member

camargo commented Apr 5, 2023

Ah got it thanks, don't mind me :)

@lklyne lklyne added the figma items related to improving design assets + organization in figma label Apr 6, 2023
@lklyne
Copy link
Collaborator Author

lklyne commented Apr 6, 2023

I can see the confusion here! I added a "figma" label for refactoring design assets that won't impact code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwhuffman bwhuffman

Labels
figma items related to improving design assets + organization in figma
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@camargo @lklyne @bwhuffman