Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text contrast in ThumbnailCarousel #528

Open
stephiescastle opened this issue Jul 31, 2024 · 2 comments
Open

Text contrast in ThumbnailCarousel #528

stephiescastle opened this issue Jul 31, 2024 · 2 comments

Comments

@stephiescastle
Copy link
Member

stephiescastle commented Jul 31, 2024

Text contrast in partially visible slides isn't passing accessibility tests. These slides are more "decorative," so I'm not quite sure how to handle this, or even if they are truly decorative or not.

http://localhost:6006/?path=/story/templates-pageimagedetail--base-story

image

I've removed PageImageDetail from our CI accessibility tests. We should re-enable tests for this component once we work out the best way to handle this.

Another Oddity: The ThumbnailCarousel tests pass. It is specifically how that component is used in PageImageDetail that doesn't pass.

@Scotchester
Copy link
Member

That's an interesting one. I think you could argue that it's not important for the text to be legible, that the whole card is there to hint that there is more in the carousel. Not sure how to tell the automated tests that, though…

@Archetipo95
Copy link

Did you try with aria-hidden attribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants