-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add FancyboxButton
Storybook stories
#41
Comments
I'll work on adding this as part of #105 |
I decided to tackle this separately from #105. I created a branch that adds a story, but I'm thinking of pushing this off for a later release. The FancyboxButton template we have and are currently using throughout our templates makes a lot of assumptions under the hood, and trying to document how to use it alongside Fancyapps' own documentation is confusing. Essentially, users just need to know what data attributes to add to a an HTML element. The names of the data-attributes don't line up with our prop names, and I'm not sure it's worthwhile to rename/restructure everything for this reason. Unfortunately, fancyapps doesn't have great documentation about all of the data attributes that are available for fancybox, so we may want to consider adding our own docs on that, but I don't think it's necessary for the 1.0.0 release. |
Adding this issue that came out from this pull request discussion:
The text was updated successfully, but these errors were encountered: