Missing name on approved submitter users prevents them from submitting change requests

[dakota002]

When a submitter tried to submit a change request, but has not set their Name, they see the standard 403 error message. This is unclear, as it tells them to sign in when they already are.

Current behavior

The user sees a 403 error telling them to sign in

Expected behavior

If the user is already verified, they should be prompted to fill in their name and optionally their affiliation data before going to the edit page.

Steps to reproduce

Environment

Dev, Test, and Prod, any browser/OS

[lpsinger]

If the user is already verified, they should be prompted to fill in their name and optionally their affiliation data before going to the edit page.

Why do they need to fill in their name in order to submit a change request? Our code probably currently requires it, but maybe it shouldn't.

[dakota002]

Yea, there is a check in the correction page that checks first if the user.name property is present, then if user.email is present. And if one is missing it just throws the same 403 error either way.

What do you think the proper behavior should be? I just threw this one together quickly after a ticket came in where a user experienced this