Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to remix > 2.10.3 breaks hyperlinks for Circulars cross-references #2564

Open
lpsinger opened this issue Sep 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lpsinger
Copy link
Member

lpsinger commented Sep 4, 2024

Follow-up of #2563.

Current behavior

If we update all of the @remix-run/* packages to versions newer than (but not including) 2.10.3, then on pages for Circulars that contain many cross-references, we find that some of the hyperlinks to other Circulars don't work. Clicking the Circulars hyperlink causes the URL to update in the address bar, but the page itself does not update.

Expected behavior

The page should update.

Steps to reproduce

  1. Update all Remix packages to versions newer than (but not including) 2.10.3.
  2. Run npm run dev.
  3. Navigate to http://localhost:3333/circulars/34576.
  4. Try to follow any of the Circulars cross-reference hyperlinks

Environment

Any browser, desktop or mobile.

Notes

I used git bisect on the remix project and came up with a list of candidate commits that might have introduced this buggy behavior. I ruled out a few of the matching commits because they only updated package metadata or non-functional files like TypeScript .d.ts files. Here are the candidates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants