Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout should be reset when write to IpStackTcpStream #5

Closed
xmh0511 opened this issue Dec 12, 2023 · 1 comment
Closed

timeout should be reset when write to IpStackTcpStream #5

xmh0511 opened this issue Dec 12, 2023 · 1 comment
Assignees

Comments

@xmh0511
Copy link
Contributor

xmh0511 commented Dec 12, 2023

IIUC, the current logic for TCP's timeout is whenever some traffic can be read from tun, the timeout will be reset. However, when doing long-time write to TCP(i.e. write to tun), we do not reset the timeout value, which will cause the timeout when poll_read is invoked. I think the timeout logic should be similar to what has been done for UDP. Whenever there is some traffic on the stream, the deadline should be extended.

@SajjadPourali SajjadPourali self-assigned this Dec 12, 2023
@SajjadPourali
Copy link
Collaborator

#23
#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants