Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support Tablets - please fix this #107

Open
evanjmg opened this issue Apr 5, 2019 · 3 comments
Open

Does not support Tablets - please fix this #107

evanjmg opened this issue Apr 5, 2019 · 3 comments

Comments

@evanjmg
Copy link

evanjmg commented Apr 5, 2019

if (@available(iOS 9.0, *)) {

If I run this on a tablet this line makes it not available when it should be available.

@koenpunt
Copy link
Collaborator

koenpunt commented Apr 8, 2019

What kind of fix do you propose?

@evanjmg
Copy link
Author

evanjmg commented Apr 8, 2019

😓 not sure, I just got rejected from Apple since isAvailable didn’t work for their test device. Still having trouble reproducing locally. I removed it and just made sure I only require iOS 10^ for devices - and they accepted it. Perhaps note that it isn’t really necessary?

@LinusU
Copy link

LinusU commented Aug 23, 2019

React Native only support iOS 9 and newer so shouldn't be a problem to just remove the check? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants