Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage to CI #128

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Add test coverage to CI #128

wants to merge 28 commits into from

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Apr 12, 2022

Description

  • Unit test have been added to the project (although only as skeletons).

Motivation and Context

  • The CI should check them.
  • NOTE: they are currently skipped as they are not yet used!

How Has This Been Tested?

  • The CI runs sucessfully.

Screenshots

image

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@networkfusion networkfusion changed the base branch from main to add-unittest-skeleton April 12, 2022 22:09
azure-pipelines.yml Outdated Show resolved Hide resolved
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment on the change, the new task adding coverage report LGTM.

Base automatically changed from add-unittest-skeleton to main December 19, 2022 17:20
@networkfusion networkfusion changed the title Add Code Coverage Add Tests and Code Coverage to CI Dec 19, 2022
Comment out failed test
@networkfusion networkfusion changed the title Add Tests and Code Coverage to CI Add Tests to CI Dec 19, 2022
@networkfusion networkfusion marked this pull request as ready for review December 19, 2022 21:57
@networkfusion networkfusion changed the title Add Tests to CI Add Test coverage to CI Dec 19, 2022
@networkfusion networkfusion changed the title Add Test coverage to CI Add test coverage to CI Dec 19, 2022
@networkfusion networkfusion requested review from josesimoes and removed request for josesimoes August 23, 2023 13:03
@networkfusion networkfusion marked this pull request as draft August 23, 2023 13:30
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants