Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Add Naming Conventions for JavaScript #37

Open
3 tasks
farbodsaraf opened this issue Dec 26, 2019 · 0 comments
Open
3 tasks

[New Feature] Add Naming Conventions for JavaScript #37

farbodsaraf opened this issue Dec 26, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers Size: L Effort/Complexity Size is Large

Comments

@farbodsaraf
Copy link
Member

farbodsaraf commented Dec 26, 2019

Add JavaScript as a topic

We are currently missing the whole topic for JavaScript naming conventions.

Acceptance Criteria:

  • Add at least 5 different topics for JavaScript naming conventions.
  • Add a home page for JavaScript naming conventions and list all the covered section.
  • Make sure nothing is copied from internet. All the examples and descriptions should be original, otherwise we get penalized by Google for a copied content.

If it is the first time that you contribute to NamingConvention.org, follow these steps: (you need to have make and yarn available on your machine)

  1. Write a comment there to let other possible contributors know that you are working on this bug.
  2. Fork the repo
  3. Run git clone https://github.com/<YOUR_USERNAME>/naming-convention.git && cd babel
  4. Run yarn && make bootstrap
  5. Wait ⏳
  6. Run make watch (or make build whenever you change a file)
  7. Add a test if needed (only input.js; output.js will be automatically generated)
  8. Update the code!
  9. yarn jest babel-preset-env to run the tests
    Since you don't need to write new tests, you can run OVERWRITE=true yarn jest babel-preset-env and they will be automatically updated.
  10. If it is working, run make test to run all the tests
  11. Run git push and open a PR!
@farbodsaraf farbodsaraf added enhancement New feature or request good first issue Good for newcomers Size: L Effort/Complexity Size is Large labels Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Size: L Effort/Complexity Size is Large
Projects
None yet
Development

No branches or pull requests

1 participant