-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync support for accurate domain status #3
Comments
jas8522
added a commit
to websavers/WHMCS-NameSilo
that referenced
this issue
Nov 16, 2021
This allows WHMCS to handle statuses from the various stages of expiry, like expired, expired grace, etc. Note: the $code === 200 conditional on line 1380 handles the truly necessary cases to force a cancelled status. Fixes namesilo#3
Any update on this ? |
Since they don't seem keen on merging those pull requests, I've created a fork with my patches applied: https://github.com/websavers/WHMCS-NameSilo |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the sync function decides a domain is either of the following:
In other words, the sync will mark the domain as "Cancelled" immediately after its expiration time without account for the fact that a domain enters "Expired" status after this time. This creates some troubles, for instance, the invoice in WHMCS is not cancelled and the user can still pay the fee to renew the domain, but the problem is that if the service (in this case the domain) is with the "Cancelled" status, WHMCS will not trigger the "invoice paid" actions, which in this case is to send the renewal request to the registrar for the domain to be renewed.
Another issue is that with domains which are in "Grace" and "Redemption", these statuses are not reflected in WHMCS (as described earlier that the sync function marks the domain as "Cancelled" only immediately after its expiration time), thus this creates some troubles where there's extra fees for redemption for some TLDs. Now WHMCS already pays attention to these situations, but only if the domain status is correctly set (either to Grace or Redemption).
It would be more useful if the statuses are set more accurately as:
Outbound Transfer
at NameSilo.Expired (grace period)
at NameSilo.Expired (restore period)
at NameSilo.Surprisingly the separate
namesilo-domain-sync.php
cron file sets the domain status in WHMCS according to the correct ones that appear at NameSilo.The text was updated successfully, but these errors were encountered: