Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason for Java 18 instead of 17? #34

Open
Dustinhoefer opened this issue Mar 11, 2024 · 1 comment
Open

Any reason for Java 18 instead of 17? #34

Dustinhoefer opened this issue Mar 11, 2024 · 1 comment

Comments

@Dustinhoefer
Copy link

Hey!

I finally got around to implementing your version of the api.
Unfortunately, I can not run it, since I am running JDK 17.

Any specific reason you are not using the LTS Version 17, but rather 18?

Kind regards
Dustin

@Dustinhoefer
Copy link
Author

Dustinhoefer commented Mar 11, 2024

I checked it out, changed to version 17 and tried to build.
Not working :/

Removed maven plugins: sign and javadoc -> building

Using that version -> Caused by: java.lang.ClassNotFoundException: retrofit2.converter.gson.GsonConverterFactory
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)

Added the following dependency seems to work:

<dependency>
        <groupId>com.google.code.gson</groupId>
        <artifactId>gson</artifactId>
        <version>2.9.0</version>
    </dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant