We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All getAsync methods are actually synchronous.
For example, getAsyncChatCompletion (in AsyncDAOImpl) returns a POJO object: ChatCompletionResponse, and it should return a Future.
You create a CompletableFuture (all well for now), but the method ends in
return (ChatCompletionResponse)future.get();
Basically, it blocks the current thread until the future completes.
For the methods to be actually async they need to return Call<> or Future
The text was updated successfully, but these errors were encountered:
@mircea-cm you are absolutely right, making a PR for this right now, should be fixed easily
Sorry, something went wrong.
namankhurpia
No branches or pull requests
All getAsync methods are actually synchronous.
For example, getAsyncChatCompletion (in AsyncDAOImpl) returns a POJO object: ChatCompletionResponse, and it should return a Future.
You create a CompletableFuture (all well for now), but the method ends in
return (ChatCompletionResponse)future.get();
Basically, it blocks the current thread until the future completes.
For the methods to be actually async they need to return Call<> or Future
The text was updated successfully, but these errors were encountered: