Skip to content

Commit

Permalink
Update nuget packages, some small fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
tinohager committed Nov 28, 2024
1 parent 456da1d commit cd99b4a
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="9.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="9.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Configuration" Version="8.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="Moq" Version="4.20.70" />
<PackageReference Include="MSTest.TestAdapter" Version="3.2.0" />
<PackageReference Include="MSTest.TestFramework" Version="3.2.0" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="9.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="MSTest.TestAdapter" Version="3.6.3" />
<PackageReference Include="MSTest.TestFramework" Version="3.6.3" />
</ItemGroup>

<ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions src/Nager.PublicSuffix/Nager.PublicSuffix.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@

<SymbolPackageFormat>snupkg</SymbolPackageFormat>

<TargetFrameworks>netstandard2.0;netstandard2.1;net6.0;net8.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;netstandard2.1;net8.0</TargetFrameworks>

<Version>3.3.0</Version>
<Version>3.4.0</Version>
</PropertyGroup>

<ItemGroup>
Expand All @@ -39,8 +39,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="9.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.0" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public CachedHttpRuleProvider(
url = "https://publicsuffix.org/list/public_suffix_list.dat";
}

this._dataFileUrl = url;
this._dataFileUrl = url ?? throw new InvalidOperationException("_dataFileUrl must contain a non-null value");
}

/// <summary>
Expand Down Expand Up @@ -82,7 +82,7 @@ public CachedHttpRuleProvider(
var tempUrl = configuration["Nager:PublicSuffix:DataUrl"];
if (!string.IsNullOrEmpty(tempUrl))
{
url = tempUrl;
url = tempUrl!;
}
}

Expand Down Expand Up @@ -123,7 +123,7 @@ public override async Task<bool> BuildAsync(
}

var ruleParser = new TldRuleParser();
var rules = ruleParser.ParseRules(ruleData);
var rules = ruleParser.ParseRules(ruleData!);

base.CreateDomainDataStructure(rules);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public SimpleHttpRuleProvider(
url = "https://publicsuffix.org/list/public_suffix_list.dat";
}

this._dataFileUrl = url;
this._dataFileUrl = url ?? throw new InvalidOperationException("_dataFileUrl must contain a non-null value");
}

/// <inheritdoc/>
Expand Down

0 comments on commit cd99b4a

Please sign in to comment.