Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tooltip addon appears to break when I create an ember modifier. #7

Open
alexmasita opened this issue Jul 20, 2023 · 3 comments
Open

Comments

@alexmasita
Copy link

alexmasita commented Jul 20, 2023

I have created a minimal repo on this link to demonstrate when the tooltip breaks. https://github.com/alexmasita/ember-tippy-test.git. It seems that when you create any ember modifier such as 'ember g modifier on-entry', this tooltip component fails to work and the tooltips fail to show. However, as you will see on the repo link provided, when you delete the modifier on the terminal via 'ember d modifier on-entry', and rerun the application, this tooltip works again. I thought it was perhaps a keyword issue and changed the name of the modifier but it still broke this addon. I see in the console multiple deprecation warnings such as "DEPRECATION: ember-modifier (in TippyForComponentModifier at Error
" and " The didInstall, didReceiveArguments, and didUpdateArguments hooks are deprecated. Use the new modify hook instead. [deprecation id: ember-modifier.use-modify] This will be removed in ember-modifier 4.0.0.". Thanks for the great plugin.

@nag5000
Copy link
Owner

nag5000 commented Jul 22, 2023

Thanks for the minimal repo. I see that you use ember-modifier 4.x and ember-tippy 2.x. Ember-tippy 2.x uses the old modifier api, which was removed in ember-modifier 4.0.0 (as written in the deprecation you mentioned above).

Please try ember-tippy 3: ember install [email protected].
The README.md still refers to ember-modifier ^3.0.0 dependency, but it seems [email protected] works okay with ember-modifier 4.1.0 - at least the tooltip in your minimal repo appears to be working.

@nag5000
Copy link
Owner

nag5000 commented Jul 22, 2023

The odd situation about ember g modifier on-entry and ember d modifier on-entry is related to how ember's build system resolves dependencies in such cases:

npm ls ember-modifier
[email protected] /ember-tippy-test
├── [email protected]
└─┬ [email protected]
  └── [email protected]

It seems it just depends on whether the app (excluding addons) has any imports from ember-modifier.

@alexmasita
Copy link
Author

Super. Will attempt your solution and report. Thanks for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants