From fc0e74db22447a4941288e7ff6e8cfb6811927f5 Mon Sep 17 00:00:00 2001
From: Nicolas Adment <39568358+nadment@users.noreply.github.com>
Date: Sun, 7 Apr 2024 23:23:33 +0200
Subject: [PATCH] Oracle databases do support prepared statement metadata
 retrieval #3515

---
 .../org/apache/hop/databases/oracle/OracleDatabaseMeta.java     | 2 +-
 .../org/apache/hop/databases/oracle/OracleDatabaseMetaTest.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/databases/oracle/src/main/java/org/apache/hop/databases/oracle/OracleDatabaseMeta.java b/plugins/databases/oracle/src/main/java/org/apache/hop/databases/oracle/OracleDatabaseMeta.java
index 09af400237d..cae0e32e057 100644
--- a/plugins/databases/oracle/src/main/java/org/apache/hop/databases/oracle/OracleDatabaseMeta.java
+++ b/plugins/databases/oracle/src/main/java/org/apache/hop/databases/oracle/OracleDatabaseMeta.java
@@ -643,7 +643,7 @@ public boolean isRequiresCreateTablePrimaryKeyAppend() {
    */
   @Override
   public boolean isSupportsPreparedStatementMetadataRetrieval() {
-    return false;
+    return true;
   }
 
   /** @return The maximum number of columns in a database, <=0 means: no known limit */
diff --git a/plugins/databases/oracle/src/test/java/org/apache/hop/databases/oracle/OracleDatabaseMetaTest.java b/plugins/databases/oracle/src/test/java/org/apache/hop/databases/oracle/OracleDatabaseMetaTest.java
index 1e9c7a4ef25..2708b022074 100644
--- a/plugins/databases/oracle/src/test/java/org/apache/hop/databases/oracle/OracleDatabaseMetaTest.java
+++ b/plugins/databases/oracle/src/test/java/org/apache/hop/databases/oracle/OracleDatabaseMetaTest.java
@@ -222,7 +222,7 @@ public void testOverriddenSettings() throws Exception {
         "http://download.oracle.com/docs/cd/B19306_01/java.102/b14355/urls.htm#i1006362",
         nativeMeta.getExtraOptionsHelpText());
     assertTrue(nativeMeta.isRequiresCreateTablePrimaryKeyAppend());
-    assertFalse(nativeMeta.isSupportsPreparedStatementMetadataRetrieval());
+    assertTrue(nativeMeta.isSupportsPreparedStatementMetadataRetrieval());
     String quoteTest1 = "FOO 'BAR' \r TEST \n";
     String quoteTest2 = "FOO 'BAR' \\r TEST \\n";
     assertEquals(