Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis chat memory has different shape than window buffer memory and can't be used as drop in replacement #11730

Open
Morriz opened this issue Nov 13, 2024 · 3 comments
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@Morriz
Copy link

Morriz commented Nov 13, 2024

Bug Description

Redis chat memory is NOT a drop-in replacement for the memory buffer, even though we may assume it is (what else is the point of making such abstractions). We should surely be able to swap a memory connector without killing our app, no?

To Reproduce

  1. create chat app with window buffer memory
  2. swap for Redis chat memory
  3. @n8n/chat client does not work anymore

Expected behavior

Memory connectors to have the same signature and output shape

Operating System

docker

n8n Version

1.66.0

Node.js Version

docker

Database

SQLite (default)

Execution mode

main (default)

@Joffcom
Copy link
Member

Joffcom commented Nov 13, 2024

Hey @Morriz,

We have created an internal ticket to look into this which we will be tracking as "GHC-440"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Nov 13, 2024
@Morriz Morriz changed the title Redis chat memory has different shape then window buffer memory and can't be used as drop in replacement Redis chat memory has different shape than window buffer memory and can't be used as drop in replacement Nov 13, 2024
@Morriz
Copy link
Author

Morriz commented Nov 13, 2024

Sooooo disappointed....I can cry

@Joffcom
Copy link
Member

Joffcom commented Nov 14, 2024

@Morriz the instructions are unclear, I have made a chat app with Window Buffer Memory nothing fancy

image

I have then loaded my chat URL and sent it a question to which it replied, All is good.

I then swapped out the Window Buffer Memory with a Redis Chat Memory

image

Set the credential and asked a question and it was all good.

What is the error you are actually seeing?

Also after yesterdays comments please keep in mind our code of conduct which you can find here: https://github.com/n8n-io/n8n/blob/master/CODE_OF_CONDUCT.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

No branches or pull requests

2 participants