Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the W versions of the Windows APIs #17

Closed
daladim opened this issue Aug 9, 2022 · 1 comment
Closed

Use the W versions of the Windows APIs #17

daladim opened this issue Aug 9, 2022 · 1 comment

Comments

@daladim
Copy link
Collaborator

daladim commented Aug 9, 2022

We're currently feeding String::as_ptr() to A versions of the Windows API.
This means we'll have unexpected results and/or UB when using non-ASCII traces names for instance.
@daladim daladim mentioned this issue Nov 7, 2022
Merged
@daladim
Copy link
Collaborator Author

daladim commented Jan 13, 2023

Done in #63

@daladim daladim closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daladim