Skip to content

+ class ThreadLatestReplierSaver to fix https://github.com/Starry-O… #131

+ class ThreadLatestReplierSaver to fix https://github.com/Starry-O…

+ class ThreadLatestReplierSaver to fix https://github.com/Starry-O… #131

Triggered via push July 10, 2024 21:19
Status Failure
Total duration 5m 3s
Artifacts

c#.yml

on: push
Matrix: runs-on
Fit to window
Zoom out
Zoom in

Annotations

30 errors, 9 warnings, and 30 notices
runs-on (macos-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L51
Remove unnecessary parenthesis. (https://code-cracker.github.io/diagnostics/CC0015.html)
runs-on (macos-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L60
Extract the assignment of '_latestRepliersKeyByUnique[uniqueLatestReplier]' from this expression. (https://rules.sonarsource.com/csharp/RSPEC-1121)
runs-on (macos-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L54
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
runs-on (macos-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L58
'ThreadPost.LatestReplier' and 'Dictionary<ThreadLatestReplierSaver.UniqueLatestReplier, LatestReplier?>.this[ThreadLatestReplierSaver.UniqueLatestReplier]' are assigned in a single statement (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.7.0/_rules/1522.md)
runs-on (macos-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L51
Remove unnecessary parenthesis. (https://code-cracker.github.io/diagnostics/CC0015.html)
runs-on (macos-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L60
Extract the assignment of '_latestRepliersKeyByUnique[uniqueLatestReplier]' from this expression. (https://rules.sonarsource.com/csharp/RSPEC-1121)
runs-on (macos-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L54
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
runs-on (macos-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L58
'ThreadPost.LatestReplier' and 'Dictionary<ThreadLatestReplierSaver.UniqueLatestReplier, LatestReplier?>.this[ThreadLatestReplierSaver.UniqueLatestReplier]' are assigned in a single statement (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.7.0/_rules/1522.md)
runs-on (macos-latest) / build (crawler)
Process completed with exit code 1.
runs-on (ubuntu-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L51
Remove unnecessary parenthesis. (https://code-cracker.github.io/diagnostics/CC0015.html)
runs-on (ubuntu-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L60
Extract the assignment of '_latestRepliersKeyByUnique[uniqueLatestReplier]' from this expression. (https://rules.sonarsource.com/csharp/RSPEC-1121)
runs-on (ubuntu-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L54
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
runs-on (ubuntu-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L58
'ThreadPost.LatestReplier' and 'Dictionary<ThreadLatestReplierSaver.UniqueLatestReplier, LatestReplier?>.this[ThreadLatestReplierSaver.UniqueLatestReplier]' are assigned in a single statement (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.7.0/_rules/1522.md)
runs-on (ubuntu-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L51
Remove unnecessary parenthesis. (https://code-cracker.github.io/diagnostics/CC0015.html)
runs-on (ubuntu-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L60
Extract the assignment of '_latestRepliersKeyByUnique[uniqueLatestReplier]' from this expression. (https://rules.sonarsource.com/csharp/RSPEC-1121)
runs-on (ubuntu-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L54
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
runs-on (ubuntu-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L58
'ThreadPost.LatestReplier' and 'Dictionary<ThreadLatestReplierSaver.UniqueLatestReplier, LatestReplier?>.this[ThreadLatestReplierSaver.UniqueLatestReplier]' are assigned in a single statement (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.7.0/_rules/1522.md)
runs-on (ubuntu-latest) / build (crawler)
Process completed with exit code 1.
runs-on (windows-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L51
Remove unnecessary parenthesis. (https://code-cracker.github.io/diagnostics/CC0015.html)
runs-on (windows-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L60
Extract the assignment of '_latestRepliersKeyByUnique[uniqueLatestReplier]' from this expression. (https://rules.sonarsource.com/csharp/RSPEC-1121)
runs-on (windows-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L54
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
runs-on (windows-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L58
'ThreadPost.LatestReplier' and 'Dictionary<ThreadLatestReplierSaver.UniqueLatestReplier, LatestReplier?>.this[ThreadLatestReplierSaver.UniqueLatestReplier]' are assigned in a single statement (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.7.0/_rules/1522.md)
runs-on (windows-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L51
Remove unnecessary parenthesis. (https://code-cracker.github.io/diagnostics/CC0015.html)
runs-on (windows-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L60
Extract the assignment of '_latestRepliersKeyByUnique[uniqueLatestReplier]' from this expression. (https://rules.sonarsource.com/csharp/RSPEC-1121)
runs-on (windows-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L54
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
runs-on (windows-latest) / build (crawler): c#/crawler/src/Tieba/Crawl/Facade/ThreadCrawlFacade.cs#L58
'ThreadPost.LatestReplier' and 'Dictionary<ThreadLatestReplierSaver.UniqueLatestReplier, LatestReplier?>.this[ThreadLatestReplierSaver.UniqueLatestReplier]' are assigned in a single statement (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.7.0/_rules/1522.md)
runs-on (windows-latest) / build (crawler)
Process completed with exit code 1.
runs-on (macos-latest) / ReSharper
Issues found.
runs-on (ubuntu-latest) / ReSharper
Issues found.
runs-on (windows-latest) / ReSharper
Issues found.
runs-on (macos-latest) / ReSharper: c#/crawler/src/Tieba/Crawl/Saver/SaverWithRevision.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Saver/SaverWithRevision.cs
runs-on (macos-latest) / ReSharper: c#/crawler/src/Tieba/Crawl/Saver/UserSaver.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Saver/UserSaver.cs
runs-on (macos-latest) / ReSharper: c#/shared/src/TransformEntityWorker.cs#L6
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /Users/runner/work/open-tbm/open-tbm/c#/shared/src/TransformEntityWorker.cs(6,162)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Tieba/Crawl/Saver/SaverWithRevision.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Saver/SaverWithRevision.cs
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Tieba/Crawl/Saver/UserSaver.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Tieba/Crawl/Saver/UserSaver.cs
runs-on (ubuntu-latest) / ReSharper: c#/shared/src/TransformEntityWorker.cs#L6
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/open-tbm/open-tbm/c#/shared/src/TransformEntityWorker.cs(6,162)
runs-on (windows-latest) / ReSharper: c#/crawler/src/Tieba/Crawl/Saver/SaverWithRevision.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on D:\a\open-tbm\open-tbm\c#\crawler\src\Tieba\Crawl\Saver\SaverWithRevision.cs
runs-on (windows-latest) / ReSharper: c#/crawler/src/Tieba/Crawl/Saver/UserSaver.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on D:\a\open-tbm\open-tbm\c#\crawler\src\Tieba\Crawl\Saver\UserSaver.cs
runs-on (windows-latest) / ReSharper: c#/shared/src/TransformEntityWorker.cs#L6
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on D:\a\open-tbm\open-tbm\c#\shared\src\TransformEntityWorker.cs(6,162)
runs-on (macos-latest) / ReSharper: c#/crawler/src/Db/LatestReplier.cs#L6
"[PropertyCanBeMadeInitOnly.Global] Property can be made init-only" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/LatestReplier.cs(6,157)
runs-on (macos-latest) / ReSharper: c#/crawler/src/Db/LatestReplier.cs#L7
"[UseSymbolAlias] Use type alias 'Uid'" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/LatestReplier.cs(7,175)
runs-on (macos-latest) / ReSharper: c#/crawler/src/Db/LatestReplier.cs#L7
"[PropertyCanBeMadeInitOnly.Global] Property can be made init-only" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/LatestReplier.cs(7,192)
runs-on (macos-latest) / ReSharper: c#/crawler/src/Db/Post/BasePost.cs#L9
"[UseSymbolAlias] Use type alias 'Uid'" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Post/BasePost.cs(9,280)
runs-on (macos-latest) / ReSharper: c#/crawler/src/Db/Post/ReplySignature.cs#L6
"[UseSymbolAlias] Use type alias 'Uid'" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Post/ReplySignature.cs(6,148)
runs-on (macos-latest) / ReSharper: c#/crawler/src/Db/Revision/AuthorRevision.cs#L7
"[UseSymbolAlias] Use type alias 'Uid'" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/AuthorRevision.cs(7,217)
runs-on (macos-latest) / ReSharper: c#/crawler/src/Db/Revision/Splitting/UserRevisions.cs#L8
"[UseSymbolAlias] Use type alias 'Uid'" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/Splitting/UserRevisions.cs(8,290)
runs-on (macos-latest) / ReSharper: c#/crawler/src/Db/User.cs#L5
"[UseSymbolAlias] Use type alias 'Uid'" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/User.cs(5,75)
runs-on (macos-latest) / ReSharper: c#/crawler/src/ExtensionMethods.cs#L12
"[UseSymbolAlias] Use type alias 'Uid'" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(12,531)
runs-on (macos-latest) / ReSharper: c#/crawler/src/ExtensionMethods.cs#L12
"[UseSymbolAlias] Use type alias 'Uid'" on /Users/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(12,565)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Db/LatestReplier.cs#L6
"[PropertyCanBeMadeInitOnly.Global] Property can be made init-only" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/LatestReplier.cs(6,157)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Db/LatestReplier.cs#L7
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/LatestReplier.cs(7,175)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Db/LatestReplier.cs#L7
"[PropertyCanBeMadeInitOnly.Global] Property can be made init-only" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/LatestReplier.cs(7,192)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Db/Post/BasePost.cs#L9
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Post/BasePost.cs(9,280)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Db/Post/ReplySignature.cs#L6
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Post/ReplySignature.cs(6,148)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Db/Revision/AuthorRevision.cs#L7
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/AuthorRevision.cs(7,217)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Db/Revision/Splitting/UserRevisions.cs#L8
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/Revision/Splitting/UserRevisions.cs(8,290)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/Db/User.cs#L5
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/Db/User.cs(5,75)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/ExtensionMethods.cs#L12
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(12,531)
runs-on (ubuntu-latest) / ReSharper: c#/crawler/src/ExtensionMethods.cs#L12
"[UseSymbolAlias] Use type alias 'Uid'" on /home/runner/work/open-tbm/open-tbm/c#/crawler/src/ExtensionMethods.cs(12,565)
runs-on (windows-latest) / ReSharper: c#/crawler/src/Db/LatestReplier.cs#L6
"[PropertyCanBeMadeInitOnly.Global] Property can be made init-only" on D:\a\open-tbm\open-tbm\c#\crawler\src\Db\LatestReplier.cs(6,157)
runs-on (windows-latest) / ReSharper: c#/crawler/src/Db/LatestReplier.cs#L7
"[UseSymbolAlias] Use type alias 'Uid'" on D:\a\open-tbm\open-tbm\c#\crawler\src\Db\LatestReplier.cs(7,175)
runs-on (windows-latest) / ReSharper: c#/crawler/src/Db/LatestReplier.cs#L7
"[PropertyCanBeMadeInitOnly.Global] Property can be made init-only" on D:\a\open-tbm\open-tbm\c#\crawler\src\Db\LatestReplier.cs(7,192)
runs-on (windows-latest) / ReSharper: c#/crawler/src/Db/Post/BasePost.cs#L9
"[UseSymbolAlias] Use type alias 'Uid'" on D:\a\open-tbm\open-tbm\c#\crawler\src\Db\Post\BasePost.cs(9,280)
runs-on (windows-latest) / ReSharper: c#/crawler/src/Db/Post/ReplySignature.cs#L6
"[UseSymbolAlias] Use type alias 'Uid'" on D:\a\open-tbm\open-tbm\c#\crawler\src\Db\Post\ReplySignature.cs(6,148)
runs-on (windows-latest) / ReSharper: c#/crawler/src/Db/Revision/AuthorRevision.cs#L7
"[UseSymbolAlias] Use type alias 'Uid'" on D:\a\open-tbm\open-tbm\c#\crawler\src\Db\Revision\AuthorRevision.cs(7,217)
runs-on (windows-latest) / ReSharper: c#/crawler/src/Db/Revision/Splitting/UserRevisions.cs#L8
"[UseSymbolAlias] Use type alias 'Uid'" on D:\a\open-tbm\open-tbm\c#\crawler\src\Db\Revision\Splitting\UserRevisions.cs(8,290)
runs-on (windows-latest) / ReSharper: c#/crawler/src/Db/User.cs#L5
"[UseSymbolAlias] Use type alias 'Uid'" on D:\a\open-tbm\open-tbm\c#\crawler\src\Db\User.cs(5,75)
runs-on (windows-latest) / ReSharper: c#/crawler/src/ExtensionMethods.cs#L12
"[UseSymbolAlias] Use type alias 'Uid'" on D:\a\open-tbm\open-tbm\c#\crawler\src\ExtensionMethods.cs(12,531)
runs-on (windows-latest) / ReSharper: c#/crawler/src/ExtensionMethods.cs#L12
"[UseSymbolAlias] Use type alias 'Uid'" on D:\a\open-tbm\open-tbm\c#\crawler\src\ExtensionMethods.cs(12,565)