Skip to content
This repository has been archived by the owner on Mar 18, 2020. It is now read-only.

HTML email styling #2

Open
euantorano opened this issue Mar 5, 2018 · 12 comments
Open

HTML email styling #2

euantorano opened this issue Mar 5, 2018 · 12 comments
Labels
enhancement New feature or request
Milestone

Comments

@euantorano
Copy link
Member

The HTML email is currently extremely basic, with no styling. It should be tidied up to match the style of the MyBB blog.

@euantorano euantorano added the enhancement New feature or request label Mar 5, 2018
@euantorano euantorano added this to the v1.0.0 milestone Mar 5, 2018
@effone
Copy link
Member

effone commented Mar 20, 2018

First of all the open <article> tag in HTML email template closes with </div>.
secondly, where are all the styling? I cant't see any inline CSS, data uri or link to any stylesheet in template.

I can come up with some mockups with responsive coded structure matching with MyBB blog site if there is chance of consideration and already not assigned to someone ...

@euantorano
Copy link
Member Author

There is no styling checked in at the moment @effone - I'm not good at that kind of stuff, and just wanted to have something readable.

@Eric-Jackson was wanting to use some email templates we purchased, but if we use them we can't include the HTML in this repository due to copyright reasons. Personally I'd like to use something open source so that we can share the code here (which makes life a lot easier to deploy this app and get it running). Not sure what @Eric-Jackson and @justinsoltesz think of that.

@effone
Copy link
Member

effone commented Mar 20, 2018

I have designed few templates few months back which I can modify and demonstrate. They are my own work, not even published anywhere. If I just be sure @Eric-Jackson or @justinsoltesz are not already working on it. I don't wanna spoil anyone's precious spent time.

@Eric-Jackson
Copy link

@effone it's just very important that they work across different OS and devices. How extensive is the testing you've done? Are they created in Mailchimp? The ones we have purchased are very high quality, I'd prefer to stick with them unless we can find an equal quality open source one.

@effone
Copy link
Member

effone commented Mar 22, 2018

@Eric-Jackson I built the template using 'fluid-hybrid' method (following an exhaustive guide of tut+) and the templates are promisingly compatible. Honestly I could not test those in all devices as I don't have all kind of device, but so far I tested it went good. The big pain is to handle android gmail app as it simply discards media queries and the followed guide was taken care of that too including other problems like mso compatibility.
No, they are not created in Mailchimp and don't have mc: template language codes, but they can be added, if required ...

No problem, if we have already spent for something we should use its value ...

@effone
Copy link
Member

effone commented Mar 23, 2018

OK. So, as much I have modified the look it comes out as:

MyBB email

Some fine-tuning might still be required, I can share the code if you guys want to take a look ...
Or, may be just stick with the purchased ones as those must be well tested and best ...

@euantorano
Copy link
Member Author

euantorano commented Mar 23, 2018 via email

@effone
Copy link
Member

effone commented Mar 27, 2018

http://git.eff.one/mybb.mail/
https://github.com/effone/mybb.mail

@euantorano
Copy link
Member Author

Awesome, thanks @effone.

@Eric-Jackson Any ideas on the best way to test this, or should I simply load it up in the live instance I've got running and fire off a post?

@effone
Copy link
Member

effone commented Mar 27, 2018

Litmus, may be.
Never used though...

@effone
Copy link
Member

effone commented Jan 6, 2019

@euantorano as stated before this is easy to simulate a test mail using Litmus and check using various devices / mail clients.

@effone
Copy link
Member

effone commented Jan 16, 2019

Refer to my earlier recommendation about Litmus, please consider looking at this Grunt Email Design Workflow repo that supports Mailgun as well as Litmus out of the box with cloud CDN support, and it produces error-free templates. I am sure this will come handy:
https://github.com/leemunroe/grunt-email-workflow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants