Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewModels belong to fragment are not getting cleared #5

Open
mwshubham opened this issue Feb 8, 2020 · 0 comments
Open

ViewModels belong to fragment are not getting cleared #5

mwshubham opened this issue Feb 8, 2020 · 0 comments
Labels
bug Something isn't working possible feature not a bug

Comments

@mwshubham
Copy link
Owner

https://github.com/mwshubham/OpenEcom/blob/b23563e2b0beece9cfbc0e3993a8de7a6f8ff5f1/home/src/main/java/app/oneecom/home/ui/cart/CartViewModel.kt#L22

fun onCleared() of Fragment's view model is not getting called. Looks like they are bind to activity instead of fragment lifecycle.
@mwshubham mwshubham added the bug Something isn't working label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working possible feature not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwshubham