Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Level 3 #1

Open
prologic opened this issue Nov 28, 2013 · 8 comments
Open

Add support for Level 3 #1

prologic opened this issue Nov 28, 2013 · 8 comments

Comments

@prologic
Copy link

Adding support for Level 3 would be nice. I plan to evaluate the use of your library in a production project at work. The spec seems fairly clear to me on Level 3 aspects. Not sure on "expressions" though.

@mwhooker
Copy link
Owner

Hi @therealprologic,

funny you should mention it. level 3 is something I plan on implementing this weekend.

@latestrevision implemented the level in go, which should be quite transferrable https://github.com/latestrevision/go-jsonselect

He also pointed me to this article which I hope should clear things up http://lloyd.io/jsonselect-grows-up

In the mean time, don't let me stop you from contributing any fixes you see

@prologic
Copy link
Author

Thats fantastic news, Look forward to it!

Sent from my iPad

On 28 Nov 2013, at 15:53, Matthew Hooker [email protected] wrote:

Hi @therealprologic https://github.com/therealprologic,

funny you should mention it. level 3 is something I plan on implementing
this weekend.

@latestrevision https://github.com/latestrevision implemented the level
in go, which should be quite transferrable
https://github.com/latestrevision/go-jsonselect

He also pointed me to this article which I hope should clear things up
http://lloyd.io/jsonselect-grows-up

In the mean time, don't let me stop you from contributing any fixes you see


Reply to this email directly or view it on
GitHubhttps://github.com//issues/1#issuecomment-29441878
.

@prologic
Copy link
Author

prologic commented Jun 4, 2014

Hi @mwhooker just wondering if you are still working on this or have lost a bit of interest? Curious more than anything :)

@prologic
Copy link
Author

prologic commented Jun 9, 2014

FAIL tests/test_conformance.py::test[level_3_basic_multiple-has-with-strings]
FAIL tests/test_conformance.py::test[level_3_expr_greater-than]
FAIL tests/test_conformance.py::test[level_3_expr_less-than]
FAIL tests/test_conformance.py::test[level_3_expr_mod]
FAIL tests/test_conformance.py::test[level_3_expr_mult]
FAIL tests/test_conformance.py::test[level_3_expr_null-eq]
FAIL tests/test_conformance.py::test[level_3_expr_precedence-2]
FAIL tests/test_conformance.py::test[level_3_expr_simple-false]
FAIL tests/test_conformance.py::test[level_3_polykids_val]

So I've been trying to work on this but running into several issues:

  • The context free grammar that jsonselect.org defines is probably more complex than what re.Scanner can provide... I'm tempted to use a proper parser such as rply, funcparserlib, pyparsing, etc.

@prologic
Copy link
Author

prologic commented Jun 9, 2014

ping @mwhooker

@danvk
Copy link

danvk commented Oct 6, 2014

Since this project seems to have stalled, I've created a new one: pyjsonselect. It's based on the JS reference implementation and hence is fully conformant with all levels of the spec. If you need the level 3 selectors, you may wish to give it a try.

@mwhooker
Copy link
Owner

mwhooker commented Oct 7, 2014

Hi All,

sorry for the radio silence. I'm no longer maintaining this, as there are far better solutions, such as http://www.jsoniq.org/ and https://github.com/boto/jmespath and now @danvk's
pyjsonselect.

danvk added a commit to danvk/JSONSelect that referenced this issue Oct 7, 2014
The author [has indicated](mwhooker/jsonselect#1 (comment)) that he's no longer maintaining it.
@prologic
Copy link
Author

prologic commented Oct 7, 2014

Awesome! Thanks guys :) I'll check these out!

James Mills / prologic

E: [email protected]
W: prologic.shortcircuit.net.au

On Tue, Oct 7, 2014 at 10:43 AM, Matthew Hooker [email protected]
wrote:

Hi All,

sorry for the radio silence. I'm no longer maintaining this, as there are
far better solutions, such as http://www.jsoniq.org/ and
https://github.com/boto/jmespath and now @danvk https://github.com/danvk's

pyjsonselect https://github.com/boto/jmespath.


Reply to this email directly or view it on GitHub
#1 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants