Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture of book without ISBN disappears after restart #6

Open
GuillaumeHM opened this issue Nov 11, 2017 · 2 comments
Open

Picture of book without ISBN disappears after restart #6

GuillaumeHM opened this issue Nov 11, 2017 · 2 comments
Assignees
Labels

Comments

@GuillaumeHM
Copy link

When I add a book with a picture and without ISBN field filled, the book with its picture appears in the book list of my_library_1 after clicking on ADD button.
If I restart the software, book still appears but without the picture. But the picture file is still in the ~/.alexandria/my_library_1/.

This bug is annoying. My Alexandria version is 0.7.1

Note : there are also pictures of book I deleted from my_library_1 (moved to my_library_2) in the folder. There is also a lot of .cover.orig picture files. I think they appear when I change the picture of a book. There should be a way to clean up all these unneeded files.

Thanks for your help

@mvz mvz added the bug label Nov 12, 2017
@g-maxime
Copy link

String.hash result isn't the same across run, so cover cannot be retrieved from book.ident

Maybe using Digest::MD5 here?

@mvz mvz self-assigned this Dec 29, 2021
@mvz
Copy link
Owner

mvz commented Dec 29, 2021

Thanks, @g-maxime for figuring this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants