From 36151610f18fabac47e2fe432d2fa1d029d08e8f Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 3 Dec 2024 20:55:01 +0000 Subject: [PATCH 1/3] chore(deps): update pre-commit-deps --- .pre-commit-config.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 0ba39e62..d4b9ef3e 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -27,7 +27,7 @@ repos: files: *buildifier_external_files args: *buildifier_external_args - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.6.0 + rev: v5.0.0 hooks: - id: check-added-large-files - id: check-ast @@ -58,7 +58,7 @@ repos: hooks: - id: clang-format - repo: https://github.com/cpplint/cpplint - rev: 1.6.1 + rev: 2.0.0 hooks: - id: cpplint args: ["--filter=-build/c++11,-build/c++14"] From a51c9de5c30a3abd900287658e942ed6ec6b3a00 Mon Sep 17 00:00:00 2001 From: Milan Vukov Date: Tue, 3 Dec 2024 22:03:22 +0100 Subject: [PATCH 2/3] Fix formatting --- examples/lifecycle/lifecycle_listener.cc | 1 + examples/lifecycle/lifecycle_service_client.cc | 1 + examples/lifecycle/lifecycle_talker.cc | 1 + examples/zero_copy/listener.cc | 1 + examples/zero_copy/talker.cc | 2 ++ ros2/test/pluginlib/ament_setup_library_tests.cc | 1 + ros2/test/pluginlib/plugin_tests.cc | 2 ++ ros2/test/pluginlib/py_loader.cc | 2 ++ ros2/test/rosbag/publisher.cc | 1 + third_party/foxglove_bridge/foxglove_bridge_node.cc | 2 ++ third_party/foxglove_bridge/foxglove_bridge_tests.cc | 3 +++ 11 files changed, 17 insertions(+) diff --git a/examples/lifecycle/lifecycle_listener.cc b/examples/lifecycle/lifecycle_listener.cc index 97b5aa7e..e875dff8 100644 --- a/examples/lifecycle/lifecycle_listener.cc +++ b/examples/lifecycle/lifecycle_listener.cc @@ -12,6 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. +#include #include #include diff --git a/examples/lifecycle/lifecycle_service_client.cc b/examples/lifecycle/lifecycle_service_client.cc index 859545ec..696b77af 100644 --- a/examples/lifecycle/lifecycle_service_client.cc +++ b/examples/lifecycle/lifecycle_service_client.cc @@ -13,6 +13,7 @@ // limitations under the License. #include +#include #include #include #include diff --git a/examples/lifecycle/lifecycle_talker.cc b/examples/lifecycle/lifecycle_talker.cc index a07b628d..b0581c6d 100644 --- a/examples/lifecycle/lifecycle_talker.cc +++ b/examples/lifecycle/lifecycle_talker.cc @@ -13,6 +13,7 @@ // limitations under the License. #include +#include #include #include #include diff --git a/examples/zero_copy/listener.cc b/examples/zero_copy/listener.cc index 94903d32..a8521c2e 100644 --- a/examples/zero_copy/listener.cc +++ b/examples/zero_copy/listener.cc @@ -15,6 +15,7 @@ #include #include +#include #include "chatter_interface/msg/chatter.hpp" #include "rclcpp/rclcpp.hpp" diff --git a/examples/zero_copy/talker.cc b/examples/zero_copy/talker.cc index d819facb..9279eedf 100644 --- a/examples/zero_copy/talker.cc +++ b/examples/zero_copy/talker.cc @@ -16,6 +16,8 @@ #include #include #include +#include +#include #include "chatter_interface/msg/chatter.hpp" #include "rclcpp/rclcpp.hpp" diff --git a/ros2/test/pluginlib/ament_setup_library_tests.cc b/ros2/test/pluginlib/ament_setup_library_tests.cc index c12e110e..76c61803 100644 --- a/ros2/test/pluginlib/ament_setup_library_tests.cc +++ b/ros2/test/pluginlib/ament_setup_library_tests.cc @@ -11,6 +11,7 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. +#include #include "console_bridge/console.h" #include "gmock/gmock.h" diff --git a/ros2/test/pluginlib/plugin_tests.cc b/ros2/test/pluginlib/plugin_tests.cc index 93505049..623b1693 100644 --- a/ros2/test/pluginlib/plugin_tests.cc +++ b/ros2/test/pluginlib/plugin_tests.cc @@ -12,6 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. +#include + #include "console_bridge/console.h" #include "gmock/gmock.h" #include "gtest/gtest.h" diff --git a/ros2/test/pluginlib/py_loader.cc b/ros2/test/pluginlib/py_loader.cc index e8bd301d..ab75c2c0 100644 --- a/ros2/test/pluginlib/py_loader.cc +++ b/ros2/test/pluginlib/py_loader.cc @@ -12,6 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. +#include + #include "console_bridge/console.h" #include "pluginlib/class_loader.hpp" #include "pybind11/pybind11.h" diff --git a/ros2/test/rosbag/publisher.cc b/ros2/test/rosbag/publisher.cc index c4e262d5..8adf5898 100644 --- a/ros2/test/rosbag/publisher.cc +++ b/ros2/test/rosbag/publisher.cc @@ -14,6 +14,7 @@ #include #include +#include #include "rclcpp/rclcpp.hpp" #include "std_msgs/msg/string.hpp" diff --git a/third_party/foxglove_bridge/foxglove_bridge_node.cc b/third_party/foxglove_bridge/foxglove_bridge_node.cc index 78a634f3..9f917614 100644 --- a/third_party/foxglove_bridge/foxglove_bridge_node.cc +++ b/third_party/foxglove_bridge/foxglove_bridge_node.cc @@ -3,6 +3,8 @@ // Adapted from https://github.com/foxglove/ros-foxglove-bridge at 0.5.3. // In the current setting Bazel rules don't support ROS 2 components, therefore, // the node is directly instantiated here. +#include + #include "foxglove_bridge/ros2_foxglove_bridge.hpp" #include "rclcpp/rclcpp.hpp" diff --git a/third_party/foxglove_bridge/foxglove_bridge_tests.cc b/third_party/foxglove_bridge/foxglove_bridge_tests.cc index bff849e1..aec4051f 100644 --- a/third_party/foxglove_bridge/foxglove_bridge_tests.cc +++ b/third_party/foxglove_bridge/foxglove_bridge_tests.cc @@ -2,7 +2,10 @@ // SPDX-License-Identifier: MIT #include #include +#include +#include #include +#include #include "foxglove_bridge/ros2_foxglove_bridge.hpp" #include "foxglove_bridge/test/test_client.hpp" From 79cf7e77fa98a75971eda0d020e9736f0b32183c Mon Sep 17 00:00:00 2001 From: Milan Vukov Date: Tue, 3 Dec 2024 22:04:23 +0100 Subject: [PATCH 3/3] Fix formatting --- ros2/test/image_common/image_transport_plugins_tests.cc | 1 + ros2/test/rosbag/recorder.cc | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ros2/test/image_common/image_transport_plugins_tests.cc b/ros2/test/image_common/image_transport_plugins_tests.cc index b21d165f..54430135 100644 --- a/ros2/test/image_common/image_transport_plugins_tests.cc +++ b/ros2/test/image_common/image_transport_plugins_tests.cc @@ -11,6 +11,7 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. +#include #include "gmock/gmock.h" #include "gtest/gtest.h" diff --git a/ros2/test/rosbag/recorder.cc b/ros2/test/rosbag/recorder.cc index 27418dc6..866be361 100644 --- a/ros2/test/rosbag/recorder.cc +++ b/ros2/test/rosbag/recorder.cc @@ -11,12 +11,16 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. -#include "rosbag2_transport/recorder.hpp" +#include +#include +#include + #include "rclcpp/rclcpp.hpp" #include "rosbag2_interfaces/msg/write_split_event.hpp" #include "rosbag2_storage/storage_options.hpp" #include "rosbag2_transport/reader_writer_factory.hpp" #include "rosbag2_transport/record_options.hpp" +#include "rosbag2_transport/recorder.hpp" #include "std_msgs/msg/string.hpp" constexpr auto kTopicName = "topic";