-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS compilation fails #306
Comments
Thanks for looking into this. You can try to fix linking as in https://github.com/pybind/pybind11_bazel/blob/master/build_defs.bzl#L56-L58. If that works, please open a PR with fixes from this discussion. It's on my TODO list to create a python extension macro as in the repo above... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I understand that this has only been tested on Ubuntu 22.04, and macOS isn't even a particularly well supported target for ROS2, this is more for presenting my findings trying to make this work on a Mac than anything else.
First, the
pic_static_library
property on Mac isn't set for many static libraries, but this is easily resolved withrules_ros2/ros2/interfaces.bzl
Line 866 in 91e1b86
to restore the previous behavior.
After this, we get python linking errors
So clearly somewhere CPython is not being linked properly, unfortunately I'm not good enough at bazel to really figure out where it went wrong.
The text was updated successfully, but these errors were encountered: