Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing token errors #52

Open
heff opened this issue Sep 8, 2023 · 3 comments
Open

Handle missing token errors #52

heff opened this issue Sep 8, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@heff
Copy link
Contributor

heff commented Sep 8, 2023

  • Start a project with no Mux creds anywhere, i.e. no env.local
  • Add a video to /videos
  • Run next-video sync

It'd be good to handle this as a known error in next-video, rather than unknown from mux-node, and maybe directly people back to that part of the next-video docs.

image
@mmcc
Copy link
Contributor

mmcc commented Sep 11, 2023

This doesn't look like an up to date error, we added a big try/catch there a little while ago. I'm not sure what we should do here re: known errors, that kind of integration-specific stuff sits a level below the CLI in the handlers.

@luwes
Copy link
Collaborator

luwes commented Sep 11, 2023

I got the same error as @heff.

from this line

log.error('An unknown error occurred', err);

should be easy to make it known if it comes from @mux/node in the stack trace

@heff
Copy link
Contributor Author

heff commented Sep 26, 2023

Maybe related, it'd be nice to provide a bit nicer message when a user doesn't set up their creds correctly. I intentionally broke my creds and got this. It's not bad but could be more helpful, and I expect this to be a common issue.
image

@luwes luwes added the enhancement New feature or request label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants