Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generating useless symlink #297

Open
fain182 opened this issue Sep 19, 2024 · 3 comments
Open

Avoid generating useless symlink #297

fain182 opened this issue Sep 19, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@fain182
Copy link
Contributor

fain182 commented Sep 19, 2024

There is a symlink in public/_next-video that is automatically created every time I start the nextjs dev server, but I suppose it's useless if you don't save your asset in the filesystem.

Maybe we could create it only when is needed?

@luwes
Copy link
Collaborator

luwes commented Sep 19, 2024

That sounds reasonable to me. Happy to review a PR if you have the appetite for adding this. Cheers

@luwes luwes added the enhancement New feature or request label Sep 19, 2024
@luwes
Copy link
Collaborator

luwes commented Sep 27, 2024

@fain182 in your use case do you have any local video files that are processed by next-video?

because the symlink is still needed to show raw local video files in the player in the webpage before they are processed.
it's like a preview (though it can fail if the browser doesn't support the raw video format).
it's only in dev mode that the symlink is created.

@fain182
Copy link
Contributor Author

fain182 commented Sep 29, 2024

No, only remote videos...

The thing that bothers me the most is that it creates a symlink to a folder that doesn't exist, because I save everything via API, so I don't have the videos folder...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants