Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Support for Cloudinary provider #223

Open
SalahAdDin opened this issue Apr 5, 2024 · 10 comments
Open

[FEAT] Support for Cloudinary provider #223

SalahAdDin opened this issue Apr 5, 2024 · 10 comments
Labels
enhancement New feature or request

Comments

@SalahAdDin
Copy link

We are using Cloudinary on many of our projects for storing media data, it would be nice to have support also for Cloudinary videos in this package.

What do you think?

@heff
Copy link
Contributor

heff commented Apr 5, 2024

Yeah, that'd be a great add. 👍 Would you be interested in helping to build the Provider? You can copy one of the existing providers to get started.

Maybe @tpiros can help from the Cloudinary side?

@luwes luwes added the enhancement New feature or request label Apr 6, 2024
@SalahAdDin
Copy link
Author

We could base the provider on this package.

@SalahAdDin
Copy link
Author

Yeah, that'd be a great add. 👍 Would you be interested in helping to build the Provider? You can copy one of the existing providers to get started.

Maybe @tpiros can help from the Cloudinary side?

@heff , Do you have any tutorial about it?

@tpiros, wanna help?

@tpiros
Copy link

tpiros commented Aug 2, 2024

apologies for the late response. could you elaborate on what you need exactly? thanks!

@SalahAdDin
Copy link
Author

apologies for the late response. could you elaborate on what you need exactly? thanks!

adding a cloudinary provider to this package.

@tpiros
Copy link

tpiros commented Aug 7, 2024

@SalahAdDin - thank you for your follow up. At Cloudinary we have our CldVideoPlayer component which is compatible with Next.js. You can read more about it here and here. It's part of our next-cloudinary package. Please give it a whirl and let me know if it fits your use cases.

@SalahAdDin
Copy link
Author

@SalahAdDin - thank you for your follow up. At Cloudinary we have our CldVideoPlayer component which is compatible with Next.js. You can read more about it here and here. It's part of our next-cloudinary package. Please give it a whirl and let me know if it fits your use cases.

I would prefer something more like this package, when using next-cloudinary we are tied to use only Cloudinary as a CDN. Plus, that package still uses deprecated API from old NextJS versions.

@colbyfayock
Copy link

not intending to hijack this thread, but 👋 @SalahAdDin Next Cloudinary maintainer here, what deprecated APIs are you referring to? the package provides support for both the Pages Router and App Router if that's what you're referring to, which the Pages Router is not deprecated, otherwise curious what you're referring to

the point of using Next Cloudinary is certainly only with the use case of being a Cloudinary customer, so there's no intent with that package to provide a transferrable library like this if that's what you're looking for, but the benefit then is you can take advantage of more advanced Cloudinary APIs that you can't with this and that aren't available in other providers

@lh15
Copy link

lh15 commented Aug 28, 2024

Does the cloudinary player support server side components?

@colbyfayock
Copy link

natively, unfortunately not at this time, as i've been struggling to figure out a solution with my current setup to support both cjs and esm. however i have help on the way to address this

for now, you just need to add a very light wrapper around the component

Example of CldImage here: https://next.cloudinary.dev/nextjs-14#app-router-app

to avoid bothering everyone on this thread that might not care about a different Cloudinary package 😂 for anyone looking for help or questions, feel free to create an Issue over here: https://github.com/cloudinary-community/next-cloudinary or DM me somewhere like Twitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants