From 42e920c724ac8951bd190bad77780242f7a38655 Mon Sep 17 00:00:00 2001 From: ADTC Date: Sun, 12 May 2024 01:23:01 +0800 Subject: [PATCH 1/2] Add a note about img tag in media-poster-image.mdx This doc change is inspired by the comment by @luwes here: https://github.com/muxinc/media-chrome/issues/904#issuecomment-2104699433 --- docs/src/pages/docs/en/components/media-poster-image.mdx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/src/pages/docs/en/components/media-poster-image.mdx b/docs/src/pages/docs/en/components/media-poster-image.mdx index b674877bf..13e364969 100644 --- a/docs/src/pages/docs/en/components/media-poster-image.mdx +++ b/docs/src/pages/docs/en/components/media-poster-image.mdx @@ -14,6 +14,8 @@ For example, you can show a blurhash that mirrors the colors that will appear wi You can either use the `` component as a static image on its own, or, add the `slot="poster"` attribute to associate it with the underlying video element for click-to-play. +> This component is reliant on Javascript to load the poster image. If better control or better performance is desired, you can use `` instead. However, it doesn't support a secondary placeholder. + ## With `src` Date: Thu, 19 Sep 2024 13:36:38 -0500 Subject: [PATCH 2/2] Update docs/src/pages/docs/en/components/media-poster-image.mdx --- docs/src/pages/docs/en/components/media-poster-image.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/pages/docs/en/components/media-poster-image.mdx b/docs/src/pages/docs/en/components/media-poster-image.mdx index 13e364969..46e2c82dd 100644 --- a/docs/src/pages/docs/en/components/media-poster-image.mdx +++ b/docs/src/pages/docs/en/components/media-poster-image.mdx @@ -14,7 +14,7 @@ For example, you can show a blurhash that mirrors the colors that will appear wi You can either use the `` component as a static image on its own, or, add the `slot="poster"` attribute to associate it with the underlying video element for click-to-play. -> This component is reliant on Javascript to load the poster image. If better control or better performance is desired, you can use `` instead. However, it doesn't support a secondary placeholder. +> This component is reliant on Javascript to load the poster image. If better control or better performance is desired, you can use `` instead. Set a placeholder via the `background-image` CSS property in the `style` attribute. ## With `src`