Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output names in txt2memmap #20

Open
PeerHerholz opened this issue Mar 4, 2021 · 2 comments
Open

output names in txt2memmap #20

PeerHerholz opened this issue Mar 4, 2021 · 2 comments

Comments

@PeerHerholz
Copy link

Ahoi hoi everyone,

thanks for this amazing toolbox and great documentation.

While using it for my analyses, I used the txt2memmap function and came
across a small "inconvenience". I wanted to get memory-mapped arrays per hemisphere, but in the way the function is currently written, there's no option to specify a name for the output files. Thus, I would need to create the files in dedicated folders. Adding an e.g. prefix argument which would be used here could resolve that. Again, this is a really minor inconvenience, but adding support for specific filenames would be cool. If you find this useful, I would be happy to submit a PR for that.

Thanks again, please stay safe.

Cheers, Peer

@jbburt
Copy link
Member

jbburt commented Mar 7, 2021

Peer,

This is a great idea -- please submit a PR and I'll implement it ASAP!

Josh

@PeerHerholz
Copy link
Author

Hi @jbburt ,

thanks for the reply. Cool, I will start working on it and submit a PR asap!

Cheers, Peer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants