Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing websocket functions #243

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

ptesavol
Copy link
Contributor

  • Make the libdatachannel WebSocket support complete by adding the previously-missing functions to the WebSocket class:
     forceClose(): void;
     remoteAddress(): string | undefined;
     path(): string | undefined; 
  • Add missing open(string: url) function to the typescript typings of WebSocket
  • Replace 'libWebSocket' -> 'libdatachannel' in debug logging

@murat-dogan
Copy link
Owner

Thanks

@murat-dogan murat-dogan merged commit 8a59d41 into murat-dogan:master Apr 20, 2024
1 check passed
@murat-dogan
Copy link
Owner

Should we call also doCleanup function? I don't know if close event is triggered also on forceClose process.
If not we need to call it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants