-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTCDataChannel.onmessage throws exception when binaryType is "arraybuffer" #303
Comments
Hello and thank you for the PRs The better will be create a jest test for this. I can make it when I have time, or you can create one if you have time. what you think? |
Hello, no problem. |
And sorry about the whitespace formatting... GitHub might be messing it up. :) |
Solved by #309 |
Hi. I am trying to switch from @koush/wrtc to your library. I am using the polyfill in node.js environment. When I try to receive binary data from a RTCDataChannel, in this line, I encountered this error:
First argument to DataView constructor must be an ArrayBuffer
The argument is received as an
Uint8Array
, but then converted to a node.jsBuffer
by default, while it should in fact take into account the value ofbinaryType
before the conversion.The text was updated successfully, but these errors were encountered: