Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup not working with 2.99.x #1547

Open
lifeofguenter opened this issue Jun 29, 2023 · 3 comments
Open

Cleanup not working with 2.99.x #1547

lifeofguenter opened this issue Jun 29, 2023 · 3 comments

Comments

@lifeofguenter
Copy link
Contributor

When removing plugins from nodes or removing nodes from munin.conf, no deletion takes place, which means:

  • we have empty plugin graphs
  • nodes are not removed

My suggestion would be:

  1. use munin.conf as source of truth, delete entries from db if not found in munin.conf (during startup)
  2. during node config, update db and remove entries
@steveschnepp
Copy link
Member

I specifically didn't want to delete plugins, as it would be data destruction.

That said, the UI could be tweaked to filter out no-recently-updated plugin. then providing the option to still show them as opt-in.

@lifeofguenter
Copy link
Contributor Author

True, but then also you can end up with a bunch of empty graphs.

Maybe compromise of making this UI only setting as you mentioned.

@ovidiulixandru
Copy link

This seems to be the case with 2.0.x as well. So how do you correctly remove a decommissioned node and its outdated data?
I seem to remember this wasn't the case in earlier versions, they just disappeared from the list when simply removed from munin.conf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants