Add experiment video recording #53
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I moved the draw method from the human player to the base player class. Since I have a print_game_state attribute for every player with different defaults (False for random, True for human), there is no reason for only having the current draw method in subclasses.
* Keep draw method only in GameState of clovek_ne_jezi_se/game_agent.py * Draw game state for all moves, saving to directory
I also fixed doc path typo (meant to have this on a different commit, but lost track)
…lovek-ne-jezi-se into add-game-recording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Changes
clovek_ne_jezi_se/agents.pyplayer classes, keep only inclovek_ne_jezi_se/game_state.py. The anticipated use case of showing a picture of the game state only makes sense for interactive play, and this need has nothing to do with drawing or not, but rather how the game state drawing is displayed.