Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BoardSpace validation less flaky #42

Open
munichpavel opened this issue Feb 6, 2021 · 0 comments
Open

Make BoardSpace validation less flaky #42

munichpavel opened this issue Feb 6, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@munichpavel
Copy link
Owner

For example, this is valid (from tests/test_state.py, commit 00fc7a1

to_space=BoardSpace(
    kind='main', idx=1,
    occupied_by=EMPTY_SYMBOL,
    allowed_occupants=self.player_names + [EMPTY_SYMBOL]
)

but this is not

to_space=BoardSpace(
    kind='main', idx=1,
    occupied_by=EMPTY_SYMBOL,
    allowed_occupants=[EMPTY_SYMBOL] + self.player_names
)

as allowed_occupants check is a simple test of equality of lists, so order matters.

@munichpavel munichpavel added the good first issue Good for newcomers label Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant