Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy slice instead of iterating in wrap() #203

Open
mriise opened this issue Apr 5, 2022 · 3 comments
Open

Copy slice instead of iterating in wrap() #203

mriise opened this issue Apr 5, 2022 · 3 comments

Comments

@mriise
Copy link
Contributor

mriise commented Apr 5, 2022

digest.copy_from_slice(input_digest);
instead of

let mut i = 0;
while i < size {
digest[i] = input_digest[i];
i += 1;
}

This will stay open till rust-lang/rust#57349

@BigLep
Copy link

BigLep commented Nov 22, 2022

@mriise : will you take this?

@vmx
Copy link
Member

vmx commented Nov 23, 2022

@BigLep: this issue will likely stay open until the linked Rust issue if fixed (can be years).

@mriise
Copy link
Contributor Author

mriise commented Jan 7, 2023

(though we dont actually use lables for this repo lol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants