-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Keccak #54
Comments
Yeah absolutely, we should add all these. @diasdavid is revamping multicodec table, maybe he can assign codes for them? |
tl;dr; the multicodec table inside the multihash table is out of date See https://github.com/multiformats/multicodec/tree/spec/update, it already has codes for the algos you are looking for. If I'm reading it correctly, there is a direct mapping in implementation between sha3 and Keccak, so, should we recognize both names, or will it be acceptable for devs to use the sha3 names, since their are standard by NIST? With regards to eth_sha3, since it is a special variant, we can add it, can we call it @jbenet can we get a review on multiformats/multicodec#16, there has been some proposals with regards to multicodecs |
Its official name AFAIK, is keccak-256 so I would go with it. |
@diasdavid to be clear,
|
Here is the PR for selecting a codec code multiformats/multicodec#19 |
NIST SHA3 and Keccak differ in the padding byte only, otherwise they are the same. Of course this results in entirely incompatible hashes. The best source for Keccak is http://keccak.noekeon.org/. |
It is not a special variant. Keccak is the hashing algorithm winning the SHA3 competition and for some reason the standard got the padding byte changed. @Kubuxu is right, it should be called |
@axic understood, at first from a conversation, it sounded like eth_sha3 was not straight Keccak or sha3. I believe we can close this one now, correct? |
I think yes. |
We need support for base Keccak as well as the already added SHA-3 standard subset of Keccak.
Ethereum calls its hash algo of choice "SHA-3" but was chosen before the standard was settled, and is more accurately called "Keccak-256".
table from sha-3 wiki
further reading:
The text was updated successfully, but these errors were encountered: