-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are codes for Blake2b and Blake2s across implementations incosistent? #100
Comments
No, the first ones look incorrect. Which implementation uses 0x40 and 0x41? |
Ah, interesting, it looks like it was changed a few years ago. |
It looks like this was changed to take into account the fact that these hash functions are parameterized over their length. 0xb240 is actually blake2b-512 while 0x40 didn't actually specify the length. |
One here: multiformats/clj-multihash#11 |
True, worth mentioning that the ongoing PR #41 still has a mention to the 0x40 and 0x41. |
The descriptions of the BLAKE2 hash codes on Multiformats.io and in the IETF draft spec for multihashes suggest that the correct codes for BLAKE2 are:
|
Looks like this issue has been solved. Perhaps it would be good to mention in the list of implementations the ones that are not up to date? Thanks for the help 👍 |
I've been filing bugs but probably haven't found all of them. |
Hello, I'm not sure I'm missing something important here but in the list of implementations some use {Blake2b 0x40, Blake2s 0x41} and others {Blake2b 0xb240, Blake2s 0xb260}. The latter agreeing with multibase and multihash CSV tables.
Are both valid? Are the former old/obsolete?
The text was updated successfully, but these errors were encountered: