-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What about Base62? #74
Comments
Could you elaborate on the benefits of adding support for this codec? Multibase sits at a rather pivotal "entrypoint" in the decoding process: adding additional encodings carries implementation costs to each individual language/library. Some already unilaterally decided not to support the full gamut: richardschneider/net-ipfs-core#54 If anything we are considering dropping some of the entries: #59 (comment) |
Perhaps I missed the goal as full base-like encoding coverage. Closing this then. |
We want to try and capture all commonly used base encodings, so we should figure out the best way to support this. It is true that today some multibase implementations ship with every encoding but as far as I’m concerned this is a bug. The new However, one thing we need to worry about here is preserving namespace. We have a much more limited space we’re working with (single character) than multicodec so we do need to worry about adding encodings that are rarely used. |
Well... that is definitely fixable: we just take out a character pair (in order to allow for case insensitivity) and designate it a multi-character prefix akin to how country-code dialing works |
i know, but it means we increase the space taken up by the metadata at a much faster rate than varints. i’m also a little worried about using up the entire set because you’ll never see failures in parsing something that wasn’t actually multibase encoded. |
Is GitHub issues the right way to track this? There are already so many issues open about other codecs. Would it make sense to create a file that contains the information from those issues? |
@vmx I think this (base encodings) is a little different than codecs. There isn’t a gigantic list of prior formats to consider, nor do we expect the list of base encodings to grow a lot over time, and the multibase table is separate (do we have a proper table yet?) from the multicodec table. |
@mikeal sorry, I meant to write "Base encodings" instead of "codec".
We have at least 13 issues open about potential Base encodings. I would rather close all those and put them into a file. I don't mean to support those encodings, so it shouldn't be a table with supported codecs, it's just a matter of tracking it in a better way that cluttering the issue tracker. |
Aka alphanumeric
[0-9A-Za-z]
.The text was updated successfully, but these errors were encountered: