Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[toolpad-core] Add support for external links in dashboard navigation #4413

Open
l-astro opened this issue Nov 14, 2024 · 2 comments
Open

[toolpad-core] Add support for external links in dashboard navigation #4413

l-astro opened this issue Nov 14, 2024 · 2 comments
Labels
component: layout This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature scope: toolpad-core Abbreviated to "core" waiting for 👍 Waiting for upvotes

Comments

@l-astro
Copy link

l-astro commented Nov 14, 2024 •
edited by github-actions bot
Loading

Summary

It would be great to include support for external links in the navigation component; perhaps add a new NavigationExternal type to be added to NavigationItem?

Examples

No response

Motivation

We have several services that are as yet outside of the mui framework but the user needs visibility of them in the dashboard nav. We would like these to be nested under a single item e.g., ExternalServices > ExternalService1, ExternalService2... Currently the breadcrumbs gets muddled if these external href are child items, as the NAVIGATION expects a segment property and concatenates this string to the href.

Search keywords: navigation, routing, external link
@l-astro l-astro added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 14, 2024
@bharatkashyap bharatkashyap added waiting for 👍 Waiting for upvotes enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 14, 2024
@prakhargupta1 prakhargupta1 changed the title Add support for external links in dashboard navigation [toolpad-core] Add support for external links in dashboard navigation Nov 18, 2024
@prakhargupta1 prakhargupta1 added the scope: toolpad-core Abbreviated to "core" label Nov 18, 2024
@apedroferreira
Copy link
Member

apedroferreira commented Nov 18, 2024 •
edited
Loading

Sounds like a useful feature!
We could add something like a path or href property to navigation page items, where any path supported by a typical href attribute could be used as a string. This property would take priority over segments.

@Janpot
Copy link
Member

Janpot commented Nov 18, 2024 •
edited
Loading

Or alternatively, a renderItem prop to open up more options of customization, analog to DataGrid renderCell.

@prakhargupta1 prakhargupta1 added the component: layout This is the name of the generic UI component, not the React module! label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: layout This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature scope: toolpad-core Abbreviated to "core" waiting for 👍 Waiting for upvotes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Janpot @apedroferreira @l-astro @bharatkashyap @prakhargupta1