Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] The skeleton used when loading feels off #2602

Closed
oliviertassinari opened this issue Aug 31, 2023 · 3 comments · Fixed by #2500
Closed

[charts] The skeleton used when loading feels off #2602

oliviertassinari opened this issue Aug 31, 2023 · 3 comments · Fixed by #2500
Assignees
Labels
bug 🐛 Something doesn't work feature: Components Button, input, table, etc. scope: toolpad-studio Abbreviated to "studio"

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 31, 2023

Steps to reproduce 🕹

Steps:

  1. Open https://tools-public.mui.com/prod/pages/9r8fshsf

Current behavior 😯

A big grey flash.

Screen.Recording.2023-09-01.at.00.39.36.mov

https://mui.com/material-ui/react-skeleton/ wasn't designed to be used with large surface area.

Expected behavior 🤔

No response

Context 🔦

mui/mui-x#10194

Your environment 🌎

v0.1.24

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer feature: Components Button, input, table, etc. labels Aug 31, 2023
@apedroferreira
Copy link
Member

Ok, I thought it could still look fine and more consistent with a Skeleton after having discussed #2400 (comment) but you're right.
Let's revert back to a spinner.

@apedroferreira apedroferreira self-assigned this Sep 1, 2023
@apedroferreira apedroferreira removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 1, 2023
@Janpot
Copy link
Member

Janpot commented Sep 1, 2023

let's move the image component to a spinner as well then?

@apedroferreira
Copy link
Member

let's move the image component to a spinner as well then?

There have been no complaints about the image and images load a bit differently, so maybe it's fine to keep the skeleton for them?

@oliviertassinari oliviertassinari added the scope: toolpad-studio Abbreviated to "studio" label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work feature: Components Button, input, table, etc. scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants