Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove dataRowIdToIdLookup selector #15698

Merged
merged 5 commits into from
Dec 3, 2024
Merged

[DataGrid] Remove dataRowIdToIdLookup selector #15698

merged 5 commits into from
Dec 3, 2024

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Dec 2, 2024 •
edited
Loading

Closes #13385

Changelog

Breaking changes

  • gridRowsDataRowIdToIdLookupSelector was removed. Use gridRowsLookupSelector in combination with getRowId() API method instead.

    -const idToIdLookup = gridRowsDataRowIdToIdLookupSelector(apiRef);
-const rowId = idToIdLookup[id]
+const rowsLookup = gridRowsLookupSelector(apiRef);
+const rowId = apiRef.current.getRowId(rowsLookup[id])

@arminmeh arminmeh added breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x labels Dec 2, 2024
@arminmeh arminmeh requested a review from a team December 2, 2024 12:40
@mui-bot
Copy link

mui-bot commented Dec 2, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15698--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 23ef527

@flaviendelangle flaviendelangle changed the title [DataGrid] Remove dataRowIdToIdLookup selector [DataGrid] Remove dataRowIdToIdLookup selector Dec 2, 2024
@romgrk romgrk mentioned this pull request Dec 2, 2024
Merged
@arminmeh arminmeh force-pushed the remove-row-id-selector branch from 1c0dcf2 to 4cca27b Compare December 2, 2024 18:47
@arminmeh arminmeh enabled auto-merge (squash) December 3, 2024 11:13
@arminmeh arminmeh force-pushed the remove-row-id-selector branch from 7081582 to 3e111f1 Compare December 3, 2024 11:29
@arminmeh arminmeh force-pushed the remove-row-id-selector branch from 3e111f1 to 6487529 Compare December 3, 2024 11:46
@arminmeh arminmeh merged commit 52591dd into mui:master Dec 3, 2024
16 checks passed
@arminmeh arminmeh deleted the remove-row-id-selector branch December 3, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! performance v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Get rid of dataRowIdToIdLookup
4 participants
@arminmeh @mui-bot @MBilalShafi @cherniavskii