Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][charts] Fix anchorEl API page #15625

Merged

Conversation

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Nov 26, 2024
@mui-bot
Copy link

mui-bot commented Nov 26, 2024

Deploy preview: https://deploy-preview-15625--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 067dce6

Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #15625 will improve performances by 36.63%

Comparing oliviertassinari:chart-fix-anchor-el-docs (067dce6) with master (ee6ee3e)

Summary

⚡ 1 improvements
✅ 5 untouched benchmarks

Benchmarks breakdown

Benchmark master oliviertassinari:chart-fix-anchor-el-docs Change
ScatterChartPro with big data amount 173.6 ms 127 ms +36.63%

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 26, 2024

The performance benchmark run in dev mode, shouldn't we move this to be with process.env.NODE_ENV = production?

SCR-20241127-bdzd

https://codspeed.io/mui/mui-x/branches/oliviertassinari:chart-fix-anchor-el-docs

Oh wait, it doesn't run in a real browser but in jsdom. Hum, OK, results won't be super helpful.

@JCQuintas
Copy link
Member

The performance benchmark run in dev mode, shouldn't we move this to be with process.env.NODE_ENV = production?

SCR-20241127-bdzd

https://codspeed.io/mui/mui-x/branches/oliviertassinari:chart-fix-anchor-el-docs

Oh wait, it doesn't run in a real browser but in jsdom. Hum, OK, results won't be super helpful.

It runs on our built version, but I suppose I didn't make the jsdom run using production mode 🤔

But indeed, the goal is mainly to see in case we make mistakes or improvements. They are not meant to represent "how fast the charts are", but "how versions speeds compare"

@oliviertassinari
Copy link
Member Author

@JCQuintas Right, yeah, we will get some directional indicators from those benchmark assertions 👍. However, we can't base merge or tradeoff decisions based on them. A change could be slower in jsdom but faster in a real browser, it could be slower in dev mode, but faster in prod mod.

@oliviertassinari oliviertassinari enabled auto-merge (squash) November 27, 2024 10:38
@oliviertassinari oliviertassinari merged commit 6801300 into mui:master Nov 27, 2024
17 checks passed
@oliviertassinari oliviertassinari deleted the chart-fix-anchor-el-docs branch November 27, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants