[docs] Cleanup of the Tree View demos #13237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
docs
This was referenced May 24, 2024
|
Deploy preview: https://deploy-preview-13237--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
force-pushed
the
clean-doc-tree-view
branch
from
72fdb3d to
41825a9
Compare
noraleonte
approved these changes
May 30, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Comment on lines
-38
to
+8
| <Box sx={{ minHeight: 200, flexGrow: 1, maxWidth: 400 }}> | ||
| <RichTreeView items={MUI_X_PRODUCTS} /> | ||
| <Box sx={{ minHeight: 352, minWidth: 250 }}> |
There was a problem hiding this comment.
With the new height, going to https://mui.com/x/react-tree-view/simple-tree-view/selection/ and scrolling the page down to read the content has a lot of empty spaces. It doesn't feel as great as it could be.
Was "Fix the layout shift on all demo when you expand all the items" a problem in the first place?
Suggested change
| <Box sx={{ minHeight: 200, flexGrow: 1, maxWidth: 400 }}> | |
| <RichTreeView items={MUI_X_PRODUCTS} /> | |
| <Box sx={{ minHeight: 352, minWidth: 250 }}> | |
| <Box sx={{ minHeight: 200, minWidth: 250 }}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUI_X_PRODUCTSdataset whenever a data change is not relevant (even for basic customization examples)RichTreeViewin theSimpleTreeViewdoc, ...)slotPropson theRichTreeViewthat did not reflect the demoaria-label, IMHO either we always use it and with a meaningful title or we never use itRegarding the
MUI_X_PRODUCTS, the issue is that we loose the preview onSimpleTreeViewbecause the dataset is too big.Do you think we should find a smaller dataset (having a small dataset on some demos and a larger on others make no sense IMHO, it's hard to have the right dimensions when it varies across demos and a lot of demos where the preview could be useful don't have one)?
Preview: https://deploy-preview-13237--material-ui-x.netlify.app/x/react-tree-view/