[docs] Small changes to standardize acessibility section for Data Grid and Tree View #13224
Conversation
arthurbalduini
requested review from
flaviendelangle,
samuelsycamore and
noraleonte
arthurbalduini
changed the title
|
|
||
| | Keys | Description | | ||
| | -----------------------------------------------------------------: | :---------------------------------------------------------- | | ||
| | <kbd class="key">Arrow Left</kbd> | Navigate between cell elements | | ||
| | <kbd class="key">Arrow Bottom</kbd> | Navigate between cell elements | | ||
| | <kbd class="key">Arrow Down</kbd> | Navigate between cell elements | |
There was a problem hiding this comment.
The famous "Arrow Bottom" 😆
|
For the failing CI, rebasing on |
| @@ -31,8 +31,10 @@ The [WAI-ARIA Authoring Practices](https://www.w3.org/WAI/ARIA/apg/patterns/tree | |||
| :::info | |||
| The following key assignments apply to Windows and Linux users. | |||
|
|
|||
| On macOS replace <kbd class="key">Ctrl</kbd> with <kbd class="key">⌘ Command</kbd>. | |||
|
|
|||
| On macOS replace: | |||
There was a problem hiding this comment.
I'm not sure how correct we are here. 🤔
Those keys definitely exist on MacOS and their keyboards:
https://store.storeimages.cdn-apple.com/4982/as-images.apple.com/is/MQ052?wid=2000&hei=2000&fmt=jpeg&qlt=95&.v=1495129815011
It's only MacBooks with their limited amount of keys or any other keyboard with less keys, which remove less often used keys. 🤔
So, technically, with this we are educating users about MacOS shortcuts for keys that they MIGHT not have on their keyboard.
I'm not saying that we can't do it. Just questioning if maybe we could put a bit less emphasis on it and instead only link to a MacOS keyboard shortcut page? 🤔
There was a problem hiding this comment.
Makes total sense for me, I confess I had the idea to add it based on my personal experience with the macbook and didn't consider other MacOS devices.
Maybe we could divide it into 2 info dialogs:
- for keys that are necessarily different, like command
- for keys that might be different, like pageUp
The second one could have a sentence briefly mentioning that some devices might demand the usage of equivalent key combinations, WDYT ?
Anyways, we can split the PR: I will remove those mentions on this PR and let only the small corrections that don't rely on it, while we continue the discussion :)
There was a problem hiding this comment.
It makes sense, we can definitely put those additions as improvements that would have less emphasis than actually different buttons. 👍
arthurbalduini
force-pushed
the
docs/tree-view-data-grid-a11y-nitpicks
branch
from
0b16f47 to
62eb110
Compare
arthurbalduini
changed the title
arthurbalduini
changed the title
…rthurbalduini/mui-x into docs/tree-view-data-grid-a11y-nitpicks
…rthurbalduini/mui-x into docs/tree-view-data-grid-a11y-nitpicks
| @@ -0,0 +1,71 @@ | |||
| --- | |||
| productId: x-date-pickers | |||
| title: Date and Time Pickers - Date format and localization | |||
There was a problem hiding this comment.
Did you intend to add this page on this PR? 🤔
If so, then this title should better reflect the page content and maybe we'd need to adjust the PR title. 😉
There was a problem hiding this comment.
Looks like I did something wrong 🙈
…ta-grid-a11y-nitpicks
This reverts commit 05c8546.
Some nitpicks I found while working on the acessibility documentation for pickers.