Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Fix visual issues in Header filters #9166

Closed
wants to merge 3 commits into from
Closed

[DataGridPro] Fix visual issues in Header filters #9166

wants to merge 3 commits into from
+115 −66

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented May 30, 2023 •
edited
Loading

Fix #9335
Fix point no. 2 and 3 mentioned in #9034

Before: https://codesandbox.io/s/hardcore-tesla-z71jgp?file=/demo.tsx
After: https://codesandbox.io/s/determined-sun-fqs29w
(Best viewed on chrome)

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature labels May 30, 2023
@mui-bot
Copy link

mui-bot commented May 30, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9166--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 541.7 1,062.6 549 762.14 200.713
Sort 100k rows ms 612.7 1,102.1 612.7 881.84 167.828
Select 100k rows ms 204.5 284.5 263 250.42 33.506
Deselect 100k rows ms 146.6 304.2 275.2 243.2 60.645

Generated by 🚫 dangerJS against 8d52091

@MBilalShafi MBilalShafi marked this pull request as ready for review May 31, 2023 12:23
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work design: ui labels May 31, 2023
@oliviertassinari oliviertassinari mentioned this pull request May 31, 2023
Open
8 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MBilalShafi MBilalShafi force-pushed the fix-header-filters-visual-issues branch from aee853e to 5ba3fcd Compare June 15, 2023 22:35
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 15, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 14, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ui labels Aug 18, 2023
@zannager zannager requested a review from romgrk August 30, 2023 13:58
@romgrk
Copy link
Contributor

romgrk commented Aug 30, 2023

@MBilalShafi do you want to fix the conflicts before I review?

@MBilalShafi
Copy link
Member Author

MBilalShafi commented Aug 31, 2023 •
edited
Loading

@romgrk Please don't review yet, I plan to rebase with master after #9502 is merged which handles point no 2 of #9034 in a better way.

@romgrk romgrk removed their request for review August 31, 2023 00:55
@romgrk romgrk marked this pull request as draft August 31, 2023 00:56
@MBilalShafi
Copy link
Member Author

MBilalShafi commented Sep 20, 2023 •
edited
Loading

Will separately open one for point no. 3 of #9034 once the #9502 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer feature: Filtering Related to the data grid Filtering feature PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] Header filters warning: React does not recognize the InputLabelProps prop on a DOM element
4 participants
@MBilalShafi @mui-bot @romgrk @oliviertassinari